[dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems

[Iremonger, Bernard]

Hi Harry,

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit at intel.com>
> Sent: Friday, May 1, 2020 12:51 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>; dev at dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger at intel.com>; stable at dpdk.org
> Subject: Re: [PATCH] test/flow-classify: fix failure on dual socket systems
> 
> On 5/1/2020 12:08 PM, Harry van Haaren wrote:
> > This commit fixes failures of the flow_classify_autotest when ran on
> > dual-socket servers, as the sample application does not support more
> > than a single socket. Increasing the NB_SOCKETS value allows the test
> > to run successfully.
> >
> > Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> >
> > ---
> >
> > DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot easily
> > statically allocate the array. As a bugfix patch, I'd prefer not add
> > complexity of dynamically allocating based on rte_socket_count(),
> > hence just increasing the value seems the most pragmatic fix.
> >
> > Fixes: tag is a bit complex, code was moved in previous commit.
> > This fixes tag is against when the NB_SOCKET = 1 was introduced.
> >
> > Cc: stable at dpdk.org
> >
> 
> Thanks for the fix.
> 
> Tested-by: Ferruh Yigit <ferruh.yigit at intel.com>
> 
Tested-by: Bernard Iremonger <bernard.iremonger at intel.com

The Cc: stable at dpdk.org line should be after the fixes line in the commit message.

Otherwise

Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>