[dpdk-dev] 答复: [PATCH] net/bnxt: fix a possible stack smashing
Yuan,Linsi
yuanlinsi01 at baidu.com
Wed May 6 05:18:36 CEST 2020
Ok, I'll modify it per you suggestion
Thanks,
Yuan Linsi
________________________________
发件人: Ajit Khaparde <ajit.khaparde at broadcom.com>
发送时间: 2020年5月5日 11:42:20
收件人: Ferruh Yigit
抄送: Yuan,Linsi; Somnath Kotur; Lance Richardson; dpdk-dev
主题: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
On Thu, Apr 30, 2020 at 4:55 PM Ferruh Yigit <ferruh.yigit at intel.com<mailto:ferruh.yigit at intel.com>> wrote:
On 4/30/2020 2:37 PM, Yuan Linsi wrote:
> From: yuanlinsi01 <yuanlinsi01 at baidu.com<mailto:yuanlinsi01 at baidu.com>>
>
> We see a stack smashing as a result of defensive code missing. Once the
> nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to
> zero after doing a floor align, and we can not exit the following
> receiving packets loop. And the buffers will be overwrite, then the
> stack frame was ruined.
>
> Fix the problem by adding defensive code, once the nb_pkts is zero, just
> directly return with no packets.
>
> Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode")
> Cc: stable at dpdk.org<mailto:stable at dpdk.org>
>
> Signed-off-by: yuanlinsi01 <yuanlinsi01 at baidu.com<mailto:yuanlinsi01 at baidu.com>>
> Signed-off-by: rongdongsheng <rongdongsheng at baidu.com<mailto:rongdongsheng at baidu.com>>
Hi Yuan,
For the sign-off tag, we need "Name Surname <email at adress.com<mailto:email at adress.com>>" syntax,
for you I can see from mail thread that it is:
"Signed-off-by: Linsi Yuan <yuanlinsi01 at baidu.com<mailto:yuanlinsi01 at baidu.com>>"
Can you please share the same for the other sign-off, 'rongdongsheng'?
Yuan, Can you please send the proper first-name, last-name for rongdongsheng? Thanks
More information about the dev
mailing list