[dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

[Wisam Monther]

I agree, since this is a test application,
We can have L4 UDP/TCP rss configuration, since all
Flows/traffic are allowed here and there is nothing to be common here.

From: Ajit Khaparde <ajit.khaparde at broadcom.com>
Sent: Wednesday, May 6, 2020 5:50 AM
To: Andrew Rybchenko <arybchenko at solarflare.com>
Cc: Wisam Monther <wisamm at mellanox.com>; dpdk-dev <dev at dpdk.org>; Jack Min <jackmin at mellanox.com>; Thomas Monjalon <thomas at monjalon.net>; Jerin Jacob <jerinjacobk at gmail.com>; gerlitz.or at gmail.com; l.yan at epfl.ch
Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton



::snip::


> +             },
> +             .rx_adv_conf = {
> +                     .rss_conf.rss_hf =
> +                                     ETH_RSS_IP  |
> +                                     ETH_RSS_UDP |

May be it is better to remove ETH_RSS_UDP by default,
since it is less common that RSS for TCP because of
possible fragmentation and packets from the same
stream delivered to different CPU cores.
If we want to enable RSS on L4 headers, then UDP and TCP should be fine.
Its an example app anyway?
Otherwise we can just stick with L3 hash like some of the other examples.
::snip::