[dpdk-dev] [PATCH v5 1/5] app/flow-perf: add flow performance skeleton

Andrew Rybchenko arybchenko at solarflare.com
Wed May 6 19:15:32 CEST 2020


On 5/6/20 8:07 PM, Wisam Monther wrote:
>> -----Original Message-----
>> From: Andrew Rybchenko <arybchenko at solarflare.com>
>> Sent: Wednesday, May 6, 2020 5:26 PM
>> To: Wisam Monther <wisamm at mellanox.com>; dev at dpdk.org; Jack Min
>> <jackmin at mellanox.com>; Thomas Monjalon <thomas at monjalon.net>;
>> jerinjacobk at gmail.com; gerlitz.or at gmail.com; l.yan at epfl.ch;
>> ajit.khaparde at broadcom.com
>> Subject: Re: [dpdk-dev] [PATCH v5 1/5] app/flow-perf: add flow performance
>> skeleton
>>
>> On 5/6/20 3:36 PM, Wisam Jaddo wrote:
>>> Add flow performance application skeleton.
>>>
>>> Signed-off-by: Wisam Jaddo <wisamm at mellanox.com>
>>> ---

[snip]

>>> diff --git a/config/common_base b/config/common_base index
>>> 14000ba07..b2edd5267 100644 diff --git
>>> a/doc/guides/rel_notes/release_20_05.rst
>>> b/doc/guides/rel_notes/release_20_05.rst
>>> index b124c3f28..258b1e03e 100644
>>> --- a/doc/guides/rel_notes/release_20_05.rst
>>> +++ b/doc/guides/rel_notes/release_20_05.rst
>>> @@ -212,6 +212,16 @@ New Features
>>>    * Added IPsec inbound load-distribution support for ipsec-secgw
>> application
>>>      using NIC load distribution feature(Flow Director).
>>>
>>> +* **Added flow performance application.**
>>> +
>>> +  Add new application to test rte_flow performance.
>>> +
>>> +  Application features:
>>> +  * Measure rte_flow insertion rate.
>>> +  * Measure rte_flow deletion rate.
>>> +  * Dump rte_flow memory consumption.
>>> +  * Measure packet per second forwarding.
>> I think above lines should be added in appropriate patches which really do it.
> What do you mean?
> each feature should add it's own line in the same commit?

As I understand there features are not available if the first patch
only is applied. I.e. ideally features should be mentioned when
they are actually added (the second patch if I understand correctly).


More information about the dev mailing list