[dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing issue
Iremonger, Bernard
bernard.iremonger at intel.com
Thu May 7 11:48:10 CEST 2020
Hi Kalesh,
> -----Original Message-----
> From: Kalesh A P <kalesh-anakkur.purayil at broadcom.com>
> Sent: Thursday, May 7, 2020 10:08 AM
> To: dev at dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; Xing, Beilei
> <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Iremonger,
> Bernard <bernard.iremonger at intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing
> issue
>
> From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
>
> Note that the issue was observed in an internal Coverity scan.
>
> Fixes: e088907bb851 ("app/testpmd: add command for getting loaded DDP
> profiles")
> Cc: stable at dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
> ---
> app/test-pmd/cmdline.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> b040630..996a498 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16891,8 +16891,10 @@ cmd_ddp_get_list_parsed( #ifdef
> RTE_LIBRTE_I40E_PMD
> size = PROFILE_INFO_SIZE * MAX_PROFILE_NUM + 4;
> p_list = (struct rte_pmd_i40e_profile_list *)malloc(size);
> - if (!p_list)
> + if (!p_list) {
> printf("%s: Failed to malloc buffer\n", __func__);
> + return;
> + }
>
> if (ret == -ENOTSUP)
> ret = rte_pmd_i40e_get_ddp_list(res->port_id,
> --
> 2.10.1
./devtools/check-git-log.sh -1
Wrong headline case:
"app/testpmd: fix NULL pointer dereferencing issue": NULL --> null
Missing 'Coverity issue:' tag:
app/testpmd: fix NULL pointer dereferencing issue
Regards,
Bernard.
More information about the dev
mailing list