[dpdk-dev] [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization

[Ananyev, Konstantin]

> Subject: [PATCH v2 4/4] event/octeontx2: fix build for O1 optimization
> 
> Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using
> gcc 7.3.0
> 
> Build error
> In file included from .../drivers/event/octeontx2/ot
> x2_evdev.c:15:0:
> .../drivers/event/octeontx2/otx2_evdev_stats.h:
>     In function ‘otx2_sso_xstats_get’:
> .../drivers/event/octeontx2/otx2_evdev_stats.h:124:9:
>     error: ‘xstats’ may be used uninitialized in this function
>            [-Werror=maybe-uninitialized]
>    xstat = &xstats[ids[i] - start_offset];
>    ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> This is false positive, 'xstats_mode_count' should be preventing taking
> the loop and accessing 'xstats'.
> Returning in that case to silence the compiler warning.
> 
> Reported-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
>  drivers/event/octeontx2/otx2_evdev_stats.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/event/octeontx2/otx2_evdev_stats.h b/drivers/event/octeontx2/otx2_evdev_stats.h
> index 9d7c694ee6..74fcec8a07 100644
> --- a/drivers/event/octeontx2/otx2_evdev_stats.h
> +++ b/drivers/event/octeontx2/otx2_evdev_stats.h
> @@ -67,7 +67,7 @@ otx2_sso_xstats_get(const struct rte_eventdev *event_dev,
> 
>  	switch (mode) {
>  	case RTE_EVENT_DEV_XSTATS_DEVICE:
> -		break;
> +		return 0;
>  	case RTE_EVENT_DEV_XSTATS_PORT:
>  		if (queue_port_id >= (signed int)dev->nb_event_ports)
>  			goto invalid_value;
> --

Tested-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

> 2.25.4