[dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode

[Zhao1, Wei]

Hi, Guinan

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Guinan Sun
> Sent: Friday, May 8, 2020 4:30 PM
> To: dev at dpdk.org
> Cc: Sun, GuinanX <guinanx.sun at intel.com>; stable at dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode
> 
> The register autoneg can't be updated synchronously with flow control mode
> setting in the state of port start , so NIC statistics error occurs. The patch fixes
> the issue.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index cf5f1fe70..e6c747aef 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> struct ixgbe_hw *hw)
>  	int err;
>  	uint32_t mflcn;
> 
> +	hw->mac.ops.setup_fc(hw);

1. please use base code API ixgbe_setup_fc(), do not use internal function directly.
2. please more info for this patch, what register error you want to fix, and why it can fix.
 

> +
>  	err = ixgbe_fc_enable(hw);
> 
>  	/* Not negotiated is not an error case */
> --
> 2.17.1