[dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency

Bruce Richardson bruce.richardson at intel.com
Mon May 11 10:41:22 CEST 2020


On Mon, May 11, 2020 at 12:29:17AM +0200, Thomas Monjalon wrote:
> 30/04/2020 18:01, Ciara Power:
> > This patch moves telemetry further down the build, and adds it as a
> > dependency for EAL. Telemetry V2 is now configured to build by default,
> > and the legacy support is built when the telemetry config flag is set.
> > 
> > Telemetry now has EAL flags, shown below:
> > "--telemetry" = Enables telemetry (this is default if no flags given)
> 
> What is the need for enabling something already enabled?
> 
So we don't get an error when somebody who used to pass in the parameter
e.g. from their scripts, continues to do so. Having it on the list is
pretty harmless, but helps a lot with backward compatibility.

> > "--no-telemetry" = Disables telemetry
> [...]
> > +	case OPT_TELEMETRY_NUM:
> > +		break;
> > +	case OPT_NO_TELEMETRY_NUM:
> > +		conf->no_telemetry = 1;
> > +		break;
> 
> I feel one option would be enough.
> 



More information about the dev mailing list