[dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode

Ferruh Yigit ferruh.yigit at intel.com
Mon May 11 22:29:28 CEST 2020


On 5/11/2020 7:19 PM, Dekel Peled wrote:
> Repo link:
> https://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=40513808b165f7436389bfffcc8a35dbdc93121c

I mean as following:
commit 40513808b165 ("doc: refine ethernet and VLAN flow rule items")

> 
> Regards,
> Dekel
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> Sent: Monday, May 11, 2020 8:19 PM
>> To: Dekel Peled <dekelp at mellanox.com>; Matan Azrad
>> <matan at mellanox.com>; Slava Ovsiienko <viacheslavo at mellanox.com>;
>> Raslan Darawsheh <rasland at mellanox.com>
>> Cc: dev at dpdk.org; stable at dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item
>> in DV mode
>>
>> On 5/5/2020 1:57 PM, Dekel Peled wrote:
>>> In existing implementation, using wild card VLAN item is not allowed.
>>> A VLAN item in flow pattern must include VLAN ID (vid) value.
>>> This obligation contradics the intention of documentation update [1].
>>
>> At this perspective it is not "documentation update" but "flow API
>> spec/contract".
>>
>>>
>>> This patch updates the VLAN item validation and translation, to allow
>>> wild card VLAN item, without VLAN ID value.
>>> User guide and release notes are updated accordingly.
>>>
>>> [1]
>>>
>> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
>>>
>> es.dpdk.org%2Fpatch%2F69207%2F&data=02%7C01%7Cdekelp%40mell
>> anox.co
>>>
>> m%7Ca4d34826f0104f0bfa4a08d7f5cf7090%7Ca652971c7d2e4d9ba6a4d14925
>> 6f461
>>>
>> b%7C0%7C0%7C637248143603832039&sdata=j%2BjcdLaYQ7Kzgdnq454X
>> q8RWfdl
>>> S7oFBibFgUjruGhk%3D&reserved=0
>>
>> Can you please refer to the commit in the repo, instead of a superseded
>> patch in patchwork?
>>
>> Will update above while merging.
>>
>>>
>>> Fixes: 00f75a40576b ("net/mlx5: fix VLAN match for DV mode")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: Dekel Peled <dekelp at mellanox.com>
>>> Acked-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
>>
>> <...>
> 



More information about the dev mailing list