[dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors

Akhil Goyal akhil.goyal at nxp.com
Tue May 12 15:19:10 CEST 2020


Hi Adam,
> 
> Hi Anoob.
> 
> What's wrong with this test? Is this unit test failing on any PMD now?
> I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G,
> SCHEDULER) and it passes everywhere. Then why should we remove it
> completely?
> 

The problem is not with the valid cases. It is the negative cases which will cause issue
On most of the hardware PMDs which do not use qp_conf and simply ignore the values set in qp_conf.
So it actually does not matter whether you set valid or invalid value for those PMDs

I believe negative test should not be there for parameters which are optional to be used.
And IMO the patch is fine.

Regards,
Akhil


More information about the dev mailing list