[dpdk-dev] [PATCH 3/5] telemetry: fix closing socket fd on error
Ciara Power
ciara.power at intel.com
Tue May 12 17:29:00 CEST 2020
The socket fd is now being closed when the connection fails.
Coverity issue: 358444
Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
Cc: ciara.power at intel.com
Signed-off-by: Ciara Power <ciara.power at intel.com>
---
lib/librte_telemetry/telemetry_legacy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c
index 10b575adfd..72471cbfbe 100644
--- a/lib/librte_telemetry/telemetry_legacy.c
+++ b/lib/librte_telemetry/telemetry_legacy.c
@@ -100,6 +100,7 @@ register_client(const char *cmd __rte_unused, const char *params,
if (connect(fd, (struct sockaddr *)&addrs, sizeof(addrs)) == -1) {
perror("\nClient connection error\n");
+ close(fd);
return -1;
}
pthread_create(&th, NULL, &legacy_client_handler,
--
2.17.1
More information about the dev
mailing list