[dpdk-dev] [PATCH] examples/l3fwd: fix unchecked function return values

pbhagavatula at marvell.com pbhagavatula at marvell.com
Wed May 13 22:20:25 CEST 2020


From: Pavan Nikhilesh <pbhagavatula at marvell.com>

Fix unchecked return values reported by coverity.

Coverity issue: 354235
Fixes: 8bd537e9c6cf ("examples/l3fwd: add service core setup based on caps")

Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
---
 examples/l3fwd/main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 84f171f18..24ede4290 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -1112,8 +1112,9 @@ l3fwd_service_enable(uint32_t service_id)
 	/* Get the core which has least number of services running. */
 	while (slcore_count--) {
 		/* Reset default mapping */
-		rte_service_map_lcore_set(service_id,
-				slcore_array[slcore_count], 0);
+		if (rte_service_map_lcore_set(service_id,
+				slcore_array[slcore_count], 0) != 0)
+			return -ENOENT;
 		service_count = rte_service_lcore_count_services(
 				slcore_array[slcore_count]);
 		if (service_count < min_service_count) {
-- 
2.17.1



More information about the dev mailing list