[dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

[Hemant Agrawal (OSS)]

> On 14/05/2020 12:06, Hemant Agrawal (OSS) wrote:
> >
> >> On 14/05/2020 10:53, Hemant Agrawal (OSS) wrote:
> >>> [Hemant] Thanks it worked  for me. It is not showing any error for
> >>> the
> >> changes in this patchset.
> >>
> >> I tested it also - and it didn't show an error either, which confused
> >> me. As you are dropping a whole bunch of symbols from DPDK v20, it
> >> _should_ baulk at this.
> >>
> >> Need to dig a bit deeper on this.
> >
> > [Hemant] I have also made change in  libabigail.abignore. That should be
> the reason for no complains?
> 
> yes ... I discovered that since.
> are we 100% certain that no end user application would  ever have used these
> symbol?

[Hemant]  No, apps are not using & can not easily use them. 
The header files containing these symbols are also not installed. 

> 
> [suppress_variable]
>          name = rte_crypto_aead_algorithm_strings
> +; Ignore moving DPAAx stable functions to INTERNAL tag [suppress_file]
> +       file_name_regexp = ^librte_common_dpaax\.
> +[suppress_file]
> +       file_name_regexp = ^librte_mempool_dpaa\.
> +[suppress_file]
> +       file_name_regexp = ^librte_bus_fslmc\.
> +[suppress_file]
> +       file_name_regexp = ^librte_bus_dpaa\.
> +[suppress_file]
> +       file_name_regexp = ^librte_pmd_dpaa\.
> 
> > Hemant
> >>
> >> Ray K
> >>
> >>
> >