[dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

[Ferruh Yigit]

On 5/14/2020 2:43 PM, asomalap at amd.com wrote:
> From: Amaranath Somalapuram <Amaranath.Somalapuram at amd.com>
> 
> Adding API for get_module_eeprom and get_module_info.
>
> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram at amd.com>

Hi Amaranath,

I guess this is v3 of the patch, can you please use the version info and keep
the all versions in same thread (using --in-reply-to), this helps us to trace
the status or previous comments of the patch.

There are multiple change requests and comments to previous version, same seems
sent in this version, can you please addresss them first?
http://inbox.dpdk.org/dev/67d7272a-29fc-885f-ad8e-e865687e1267@intel.com/

> ---
>  doc/guides/nics/features/axgbe.ini |   1 +
>  drivers/net/axgbe/axgbe_ethdev.c   |   2 +
>  drivers/net/axgbe/axgbe_phy.h      |   4 ++
>  drivers/net/axgbe/axgbe_phy_impl.c | 107 +++++++++++++++++++++++++++++
>  4 files changed, 114 insertions(+)
> 
> diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
> index 0becaa097..80a3bcee1 100644
> --- a/doc/guides/nics/features/axgbe.ini
> +++ b/doc/guides/nics/features/axgbe.ini
> @@ -18,3 +18,4 @@ Basic stats          = Y
>  Linux UIO            = Y
>  x86-32               = Y
>  x86-64               = Y
> +Module EEPROM dump   = Y

Can you please add the items with same order as 'default.ini'