[dpdk-dev] [PATCH v2 1/2] lib/metrics: fix to reset the init flag

Stephen Hemminger stephen at networkplumber.org
Tue May 19 17:23:35 CEST 2020


On Tue, 19 May 2020 16:22:57 +0530
Hemant Agrawal <hemant.agrawal at nxp.com> wrote:

> diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
> index e07670219f..dba6409c27 100644
> --- a/lib/librte_metrics/rte_metrics.c
> +++ b/lib/librte_metrics/rte_metrics.c
> @@ -85,6 +85,7 @@ rte_metrics_deinit(void)
>  {
>  	struct rte_metrics_data_s *stats;
>  	const struct rte_memzone *memzone;
> +	int ret = 0;
>  

Why do gratuitous initialization? It blocks compiler from finding buggy
code.


More information about the dev mailing list