[dpdk-dev] [PATCH 3/3] l3fwd-power: add interrupt-only mode
Burakov, Anatoly
anatoly.burakov at intel.com
Fri May 29 16:19:45 CEST 2020
On 29-May-20 2:19 PM, Harman Kalra wrote:
>> if (ret < 0)
>> rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
>>
>> - if (app_mode != APP_MODE_TELEMETRY && init_power_library())
>> + if (app_mode == APP_MODE_DEFAULT)
>> + app_mode = APP_MODE_LEGACY;
>> +
>> + /* only legacy and empty poll mode rely on power library */
>> + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
>> + init_power_library())
>> rte_exit(EXIT_FAILURE, "init_power_library failed\n");
>>
> Hi,
>
> Rather than just exiting from here can we have a else condition to
> automatically enter into the "interrupt only" mode.
> Please correct me if I am missing something.
Hi,
Thanks for your review. I don't think silently proceeding is a good
idea. If the user wants interrupt-only mode, they should request it.
Silently falling back to interrupt-only mode will create an illusion of
successful initialization and set the wrong expectation for how the
application will behave.
--
Thanks,
Anatoly
More information about the dev
mailing list