[dpdk-dev] [PATCH v2] net/mlx5: fix interrupt installation timing
Raslan Darawsheh
rasland at mellanox.com
Sun May 31 16:04:39 CEST 2020
Hi,
> -----Original Message-----
> From: Suanming Mou <suanmingm at mellanox.com>
> Sent: Thursday, May 28, 2020 12:22 PM
> To: Slava Ovsiienko <viacheslavo at mellanox.com>; Matan Azrad
> <matan at mellanox.com>; dev at dpdk.org
> Cc: Raslan Darawsheh <rasland at mellanox.com>; stable at dpdk.org
> Subject: [PATCH v2] net/mlx5: fix interrupt installation timing
>
> Currently, the DevX counter query works asynchronously with Devx
> interrupt handler return the query result. When port closes, the
> interrupt handler will be uninstalled and the Devx comp obj will
> also be destroyed. Meanwhile the query is still not cancelled.
>
> In this case, counter query may use the invalid Devx comp which
> has been destroyed, and query failure with invalid FD will be
> reported.
>
> Adjust the shared interrupt install and uninstall timing to make
> the counter asynchronous query stop before interrupt uninstall.
>
> Fixes: f15db67 ("net/mlx5: accelerate DV flow counter query")
> Cc: stable at dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm at mellanox.com>
> Acked-by: Matan Azrad <matan at mellanox.com>
> ---
> v2: fix by adjusting the interrupt install timing.
> ---
> drivers/net/mlx5/mlx5.c | 101 +++++++++++++----
> drivers/net/mlx5/mlx5.h | 5 -
> drivers/net/mlx5/mlx5_ethdev.c | 243 ----------------------------------------
> drivers/net/mlx5/mlx5_trigger.c | 17 ++-
> 4 files changed, 97 insertions(+), 269 deletions(-)
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
More information about the dev
mailing list