[dpdk-dev] [PATCH v14 09/23] event/dlb: add xstats

McDaniel, Timothy timothy.mcdaniel at intel.com
Sun Nov 1 17:48:31 CET 2020



> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Saturday, October 31, 2020 5:00 PM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: dev <dev at dpdk.org>; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads,
> Gage <gage.eads at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Thomas Monjalon <thomas at monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH v14 09/23] event/dlb: add xstats
> 
> On Sat, Oct 31, 2020 at 7:21 PM Timothy McDaniel
> <timothy.mcdaniel at intel.com> wrote:
> > +void
> > +dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f)
> > +{
> > +       struct dlb_eventdev *dlb;
> > +       struct dlb_hw_dev *handle;
> > +       int i;
> > +
> > +       if (f == NULL) {
> > +               printf("Invalid file pointer\n");
> 
> No printf in a driver!
> 
> This check should probably be at eventdev layer level.
> 
> > +               return;
> > +       }
> > +
> > +       if (dev == NULL) {
> 
> dev can't be NULL.
> 
> 
> > +               fprintf(f, "Invalid event device\n");
> > +               return;
> > +       }
> > +
> > +       dlb = dlb_pmd_priv(dev);
> > +
> > +       if (dlb == NULL) {
> 
> I wonder if this can happen, dev_private is allocated at the same time
> the eventdev dev is.
> 
> > +               fprintf(f, "DLB Event device cannot be dumped!\n");
> > +               return;
> > +       }
> > +
> 
> 
> --
> David Marchand

Addressed in next patchset


More information about the dev mailing list