[dpdk-dev] [PATCH v2 05/14] net/ark: switch timestamp to dynamic mbuf field

Thomas Monjalon thomas at monjalon.net
Mon Nov 2 17:10:42 CET 2020


02/11/2020 16:32, Olivier Matz:
> On Sun, Nov 01, 2020 at 07:06:17PM +0100, Thomas Monjalon wrote:
> > --- a/drivers/net/ark/ark_ethdev_rx.c
> > +++ b/drivers/net/ark/ark_ethdev_rx.c
> > @@ -15,6 +15,9 @@
> >  #define ARK_RX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_RX_META_SIZE)
> >  #define ARK_RX_MAX_NOCHAIN (RTE_MBUF_DEFAULT_DATAROOM)
> >  
> > +extern uint64_t ark_timestamp_rx_dynflag;
> > +extern int ark_timestamp_dynfield_offset;
> > +
> 
> Wouldn't it be better in a .h ?
> Maybe ark_ethdev_rx.h

Yes it would allow type checking on compilation.





More information about the dev mailing list