[dpdk-dev] [kmods PATCH] windows: normalize line-endings

Luca Boccassi bluca at debian.org
Tue Nov 3 11:05:43 CET 2020


On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote:
> Hi Naty,
> 
> > Doesn't the 'input' option gets you original (unmodified) line endings on checkout?
> > If a file in the repo has CRLF endings, Unix devs will get it as-is (with CRLF), right?
> 
> The "input" option is for Unix devs only.
> 
> > Regardless, this is the best option for Unix and since we're normalizing line endings for 
> > existing files, Unix devs should get LF on checkout.
> > I will send a patch to normalize netuio as well.
> 
> AFAIK, you don't need to. Whatever you settings were when committing netuio,
> it now checks out with CRLF on Windows (core.autocrlf=true, installer
> default) and with LF on Linux (core.autocrlf=input, although unset also
> works). I'd wait for confirmation from Luca, though.

Hi,

Thank you for looking into this. Yes the netuio folder is ok as-is:

$ dos2unix -id windows/netuio/netuio.vcxproj* windows/netuio/netuio.sln
       0  windows/netuio/netuio.vcxproj
       0  windows/netuio/netuio.vcxproj.filters
       0  windows/netuio/netuio.sln

The patch looks good to me, as I really need all files to be checked in
with LF only as a hard requirement before I can upload to
Debian/Ubuntu, so:

Acked-by: Luca Boccassi <bluca at debian.org>

Does the change also stop future check-ins of CRLF files?

-- 
Kind regards,
Luca Boccassi


More information about the dev mailing list