[dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity

[oulijun]

在 2020/11/3 19:41, Ferruh Yigit 写道:
> On 11/2/2020 2:38 PM, Lijun Ou wrote:
>> From: Hongbo Zheng <zhenghongbo3 at huawei.com>
>>
>> This patch fixes some warnings.
>> coverity:function format symbol does not match
> 
> I think we are not getting these warnings in the public coverity, is 
> there a specific configuration for it?
> 
Yes, the coverity scan is configured internally instead of the DPDK CI 
coverity warning. However, we think it is reasonable.
>>
>> coverity:not_unsigned: Violation: Operand
>> "hw->hw_tc_map & (1UL << i)",  Right Expression:
>> "1UL << i" is not an unsigned type
>>
> 
> Can you please split this patch into multiple patches, one for each type 
> of issue?
> 
>> Coverity issue: 91708127
>> Coverity issue: 89776953
> 
> I assume these are internal coverity ids, it has not much value to 
> record them in the commit log.
> 
> We record the public coverity [1] ids with this tag.
Hi, Ferruh
   The warning is our configuration. As a result, it has no public id.If 
the ID is not added, the check-git-log check fails.

Do you have any good advice?

Thanks
Lijun Ou
> 
> [1]
> https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview 
> 
> 
>> Fixes: 62e3ccc2b94c ("net/hns3: support flow control")
>> Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations")
>> Fixes: a5475d61fa34 ("net/hns3: support VF")
>> Fixes: fb94f359481f ("net/hns3: fix adding multicast MAC address")
>> Fixes: fcba820d9b9e ("net/hns3: support flow director")
>> Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx 
>> queues")
>> Fixes: 2790c6464725 ("net/hns3: support device reset")
>> Fixes: 23d4b61fee5d ("net/hns3: support multiple process")
>> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
>> Fixes: e31f123db06b ("net/hns3: support NEON Tx")
>> Fixes: 8839c5e202f3 ("net/hns3: support device stats")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3 at huawei.com>
>> Signed-off-by: Lijun Ou <oulijun at huawei.com>
> 
> <...>
> 
> .
>