[dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field

[Andrew Rybchenko]

On 11/3/20 3:21 PM, Thomas Monjalon wrote:
> The mbuf timestamp is moved to a dynamic field
> in order to allow removal of the deprecated static field.
> The related dynamic mbuf flag is set, although was missing previously.
> 
> The timestamp is set if configured for at least one device.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Acked-by: David Marchand <david.marchand at redhat.com>

Just one minor comment below

> ---
>  drivers/net/ark/ark_ethdev.c    | 16 ++++++++++++++++
>  drivers/net/ark/ark_ethdev_rx.c |  7 ++++++-
>  drivers/net/ark/ark_ethdev_rx.h |  2 ++
>  3 files changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index fa343999a1..a34dcc5291 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -79,6 +79,8 @@ static int  eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t size);
>  #define ARK_TX_MAX_QUEUE (4096 * 4)
>  #define ARK_TX_MIN_QUEUE (256)
>  
> +uint64_t ark_timestamp_rx_dynflag;
> +int ark_timestamp_dynfield_offset = -1;
>  int rte_pmd_ark_rx_userdata_dynfield_offset = -1;
>  int rte_pmd_ark_tx_userdata_dynfield_offset = -1;

It is a bit confusing that naming above differs so much and
put in the same block without empty lines in between.
I guess the reason is export/no-export. May be it would
be useful to highlight it in a comment.