[dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

Bruce Richardson bruce.richardson at intel.com
Wed Nov 4 10:43:04 CET 2020


On Tue, Nov 03, 2020 at 10:51:17PM +0100, Thomas Monjalon wrote:
> 03/11/2020 21:21, Thomas Monjalon:
> > 03/11/2020 15:48, Bruce Richardson:
> > > Coverity flags a possible problem where the 8-bit wq_idx value may have
> > > errors when shifted and sign-extended to 64-bits. Since this can only occur
> > > if the shift index is larger than any expected value from hardware, it's
> > > unlikely to cause any real problems, but we can eliminate any
> > > possible errors, and the coverity issue, by explicitly typecasting
> > > the uint8_t value to 64-bits before any shift operations occur.
> > > 
> > > Coverity issue: 363695
> > > Fixes: a33969462135 ("raw/ioat: fix work-queue config size")
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > 
> > Applied, thanks
> 
> Actually no, sorry for the confusion, there is a build issue
> with 32-bit compiler:
> 	error: cast to pointer from integer of different size
> 
> (thanks David for the heads up)
> 
Ok, thanks for heads-up, I'll see about a v2.


More information about the dev mailing list