[dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing

[Thomas Monjalon]

04/11/2020 22:00, David Christensen:
> 
> On 11/4/20 11:43 AM, Thomas Monjalon wrote:
> >> Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
> >> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
> >> ---
> >> -#ifdef VFIO_IOMMU_SPAPR_INFO_DDW
> >> -		/* try possible page_shift and levels for workaround */
> >> +		/* if at first we don't succeed, try more levels */
> >>   		uint32_t levels;
> >>   
> >> -		for (levels = create->levels + 1;
> >> +		for (levels = create.levels + 1;
> >>   			ret && levels <= info.ddw.levels; levels++) {
> > 
> > There is a compilation failure with ppc64le-power8-linux-gcc:
> > error: ‘struct vfio_iommu_spapr_tce_info’ has no member named ‘ddw’
> 
> How did you find that error?  It builds locally for me on a POWER system 
> with Meson/gcc and there were no build failures on Travis 
> (https://travis-ci.com/github/drchristensen/dpdk/builds/198047029) when 
> I checked it against AMD64/ARM systems.  The code is PPC specific but it 
> will build on all architectures (there are no IFDEFs around it).

Remember, I cross-build with test-meson-builds.sh
Is it an issue of my toolchain?