[dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style

Ferruh Yigit ferruh.yigit at intel.com
Fri Nov 6 17:44:24 CET 2020


On 11/6/2020 3:51 AM, Lijun Ou wrote:
> From: Hongbo Zheng <zhenghongbo3 at huawei.com>
> 
> Here adjusts some code style for making the lines more
> compact and removes some static check tool warnings.
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3 at huawei.com>
> Signed-off-by: Lijun Ou <oulijun at huawei.com>
> ---
> V1->V2:
> - fix checkpatch warning
> ---
>   drivers/net/hns3/hns3_cmd.c    |   1 -
>   drivers/net/hns3/hns3_ethdev.c |   6 +-
>   drivers/net/hns3/hns3_ethdev.h |   1 -
>   drivers/net/hns3/hns3_flow.c   |  37 +-
>   drivers/net/hns3/hns3_intr.c   | 873 +++++++++++++++++++++++++++--------------
>   drivers/net/hns3/hns3_rxtx.c   |   1 -
>   drivers/net/hns3/hns3_stats.c  |   1 -
>   7 files changed, 597 insertions(+), 323 deletions(-)

This is a big(ish) patch with just whitespace changes, looks like related to the 
personal preferences.
This will create noise in the git history, and unnecessary conflict in 
backporting patches.

I know it is tempting to fix here or there :), but lets fix those when updating 
those lines for a functional change, and drop this patch.


More information about the dev mailing list