[dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

[David Marchand]

On Fri, Oct 23, 2020 at 1:23 PM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
> On 10/22/20 10:59 AM, Cheng Jiang wrote:
> > This patch set makes vhost-vswitch be able to use vhost async APIs
> > for enqueue operations. Demonstrated how the application
> > leverage IOAT DMA channel with vhost async APIs.
> >
> > We introduce two parameters to enable DMA acceleration for Tx
> > operations of queues:
> > -dma_type This parameter is used to specify DMA type for async
> > vhost-user net driver.
> > -dmas This parameter is used to specify the assigned DMA device of a
> > vhost device and enable async vhost data path.
> >
> >
> > Cheng Jiang (4):
> >   example/vhost: add async vhost args parsing function
> >   example/vhost: add support for vhost async data path

- This series breaks external compilation, as the external Makefile
was not updated.

/usr/bin/ld: /tmp/cce4w26j.o: in function `new_device':
main.c:(.text+0x173): undefined reference to `ioat_transfer_data_cb'
/usr/bin/ld: main.c:(.text+0x178): undefined reference to
`ioat_check_completed_copies_cb'
/usr/bin/ld: /tmp/cce4w26j.o: in function `main':
main.c:(.text.startup+0x25e): undefined reference to `open_ioat'
collect2: error: ld returned 1 exit status


- This series imposes a dependency on the raw/ioat driver for no reason.

$ meson configure build -Ddisable_drivers=raw/ioat
$ ninja-build -C build -j4
...
examples/meson.build:91:4: ERROR:  Problem encountered: Missing
dependency "raw_ioat" for example "vhost"

The check for the architecture == x86 is wrong.
The example must check for RTE_RAW_IOAT presence.


Please provide fixes before rc4 or I will revert this series.
Thanks.


-- 
David Marchand