[dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half

Thomas Monjalon thomas at monjalon.net
Mon Nov 9 13:59:49 CET 2020


09/11/2020 13:01, Jerin Jacob:
> Hi @Thomas Monjalon
> 
> Any specific reason why you removed the static assert from octeontx2.

I have a build failure when cross-compiling for octeontx2.

> I am not able to compilation issue with that static assert.

There is no issue when compiling for x86.

> The current vector driver assumes pool and tx offload needs to 2 DWORDS apart,
> Which is the case before and after your change.

You're right, pool and tx_offload are moved together.
The only difference is passing the cache line frontier.

> Please remove that static assert change, No issue from my side on this patch.

I cannot remove it without fixing something else,
maybe an issue in cache line alignment?

> In general, it is too much effort to re-verify and measure performance
> impact with
> all the cases after RC2, I hope this will last mbuf change in this release.

Yes it is the last change to mbuf layout,
sorry for pushing all these changes so late.





More information about the dev mailing list