[dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

Stephen Hemminger stephen at networkplumber.org
Mon Nov 9 17:20:21 CET 2020


On Mon, 9 Nov 2020 16:10:45 +0000
Bruce Richardson <bruce.richardson at intel.com> wrote:

> On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote:
> > On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson
> > <bruce.richardson at intel.com> wrote:  
> > >
> > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote:  
> > > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger
> > > > <stephen at networkplumber.org> wrote:  
> > > > > > This patch causes build failures which persist until patch 3, because of
> > > > > > these deprecations. I think you need to define the backward-compatibility
> > > > > > macros here, but only mark them deprecated at the end of the set.
> > > > > >
> > > > > > /Bruce  
> > > > >
> > > > > Is building without warnings in every step that important?
> > > > > The previous patch series for master/slave had the same effect  
> > > >
> > > > Thomas fixed it while applying.
> > > > https://patchwork.dpdk.org/cover/80987/#122107
> > > >
> > > >  
> > > In this case I believe the below needs to be applied to patch 1, and then
> > > the inverse of it set as patch 4 to mark the compatibility macros as
> > > deprecated.  
> > 
> > Or just squash the patches and be done with it, like I already commented.
> > No one cares about this series anyway.
> >   
> Ok, yep, that's fine too.
> 
> /Bruce

Agree, go ahead and combine the patches.
They were split for testing and review.


More information about the dev mailing list