[dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2

[Ferruh Yigit]

On 11/11/2020 6:48 AM, Jiawen Wu wrote:
> This patch adds the rest of txgbe PMD for its PF part.
> Support include flow API, traffic manager, macsec and ipsec.
> 
> v2:
> - Rebase on next-net
> 
> Jiawen Wu (37):
>    net/txgbe: add ntuple filter init and uninit
>    net/txgbe: support ntuple filter add and delete
>    net/txgbe: add ntuple parse rule
>    net/txgbe: support ntuple filter remove operaion
>    net/txgbe: support ethertype filter add and delete
>    net/txgbe: add ethertype parse rule
>    net/txgbe: support syn filter add and delete
>    net/txgbe: add syn filter parse rule
>    net/txgbe: add L2 tunnel filter init and uninit
>    net/txgbe: config L2 tunnel filter with e-tag
>    net/txgbe: support L2 tunnel filter add and delete
>    net/txgbe: add L2 tunnel filter parse rule
>    net/txgbe: add FDIR filter init and uninit
>    net/txgbe: configure FDIR filter
>    net/txgbe: support FDIR add and delete operations
>    net/txgbe: add FDIR parse normal rule
>    net/txgbe: add FDIR parse tunnel rule
>    net/txgbe: add FDIR restore operation
>    net/txgbe: add RSS filter parse rule
>    net/txgbe: add RSS filter restore operation
>    net/txgbe: add filter list init and uninit
>    net/txgbe: add generic flow API
>    net/txgbe: add flow API create function
>    net/txgbe: add flow API destroy function
>    net/txgbe: add flow API flush function
>    net/txgbe: support UDP tunnel port add and delete
>    net/txgbe: add TM configuration init and uninit
>    net/txgbe: add TM capabilities get operation
>    net/txgbe: support TM shaper profile add and delete
>    net/txgbe: support TM node add and delete
>    net/txgbe: add TM hierarchy commit
>    net/txgbe: add macsec setting
>    net/txgbe: add IPsec context creation
>    net/txgbe: add security session create operation
>    net/txgbe: support security session destroy
>    net/txgbe: add security offload in Rx and Tx process
>    net/txgbe: add security type in flow action

Hi Jiawen,

There are multiple build errors on patch by patch build, can you please check 
it, the expectation is after each commit build and functionality shouldn't be 
broken.

I put some comments to the patches, with a change request how to construct the 
patchset.

All these new features are not documented in the driver documentation, it can be 
documented with more details.

And the patchset is loaded, it has many new features, it is up to you but 
instead of adding all to -rc4, I suggest postponing this set to next release and 
use longer time for better implementation.

Thanks
ferruh