[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation

Slava Ovsiienko viacheslavo at nvidia.com
Thu Nov 12 18:04:15 CET 2020


> -----Original Message-----
> From: Maxime Leroy <maxime.leroy at 6wind.com>
> Sent: Thursday, November 12, 2020 17:39
> To: Matan Azrad <matan at nvidia.com>; Shahaf Shuler <shahafs at nvidia.com>;
> Slava Ovsiienko <viacheslavo at nvidia.com>; Alexander Kozyrev
> <akozyrev at nvidia.com>
> Cc: dev at dpdk.org; NBU-Contact-N?lio Laranjeiro
> <nelio.laranjeiro at 6wind.com>
> Subject: [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation
> 
> The commit d2d57605522d ("net/mlx5: fix Rx queue count calculation") is
> uncorrect because the count calculation is wrong for the next cqe:
> 
> Example:
> 
>  Compressed Set of packets 1  |   Compressed Set of packets 2
> C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0
> 
> There are 2 compressed set of packets in the first queue. For the first set, n is
> computed correctly.
> 
> But for the second, n is not computed properly. Because the zip context is for
> the first set. The  second set is not yet decompressed, so there are no context.
> 
> To fix the issue, we should only use the zip context for the first CQEs serie.
> 
> Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation")
> Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>

Thank you for the fix. The second patch is still on review - I have some doubts about final RTE_MIN(), checking.

Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>



More information about the dev mailing list