[dpdk-dev] [PATCH v2] dpdk-telemetry-client: fix some pylint warnings

Thomas Monjalon thomas at monjalon.net
Mon Nov 16 00:06:32 CET 2020


04/11/2020 08:00, Stephen Hemminger:
> Convert comments to docstrings as appropriate.

Why inserting some spaces inside the docstrings?

> Remove unnecessary paren in if statement.
> Remove extra whitespace after print.
> Remove extra semicolon; this is not C.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Some issues are remaining:

pycodestyle usertools/dpdk-telemetry-client.py
usertools/dpdk-telemetry-client.py:12:80: E501 line too long (82 > 79 characters)
usertools/dpdk-telemetry-client.py:14:80: E501 line too long (80 > 79 characters)
usertools/dpdk-telemetry-client.py:15:80: E501 line too long (86 > 79 characters)
usertools/dpdk-telemetry-client.py:18:1: E302 expected 2 blank lines, found 1
usertools/dpdk-telemetry-client.py:30:9: E722 do not use bare 'except'
usertools/dpdk-telemetry-client.py:33:1: E302 expected 2 blank lines, found 1
usertools/dpdk-telemetry-client.py:46:9: E722 do not use bare 'except'
usertools/dpdk-telemetry-client.py:50:80: E501 line too long (80 > 79 characters)
usertools/dpdk-telemetry-client.py:71:80: E501 line too long (82 > 79 characters)
usertools/dpdk-telemetry-client.py:82:80: E501 line too long (95 > 79 characters)
usertools/dpdk-telemetry-client.py:84:24: E261 at least two spaces before inline comment
usertools/dpdk-telemetry-client.py:84:25: E262 inline comment should start with '# '
usertools/dpdk-telemetry-client.py:107:32: E261 at least two spaces before inline comment
usertools/dpdk-telemetry-client.py:107:33: E262 inline comment should start with '# '
usertools/dpdk-telemetry-client.py:107:80: E501 line too long (80 > 79 characters)
usertools/dpdk-telemetry-client.py:120:13: E722 do not use bare 'except'
usertools/dpdk-telemetry-client.py:123:1: E305 expected 2 blank lines after class or function definition, found 1





More information about the dev mailing list