[dpdk-dev] [PATCH v12 11/14] build: disable Arm drivers

Juraj Linkeš juraj.linkes at pantheon.tech
Mon Nov 16 16:54:11 CET 2020



> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, November 16, 2020 9:23 AM
> To: Juraj Linkeš <juraj.linkes at pantheon.tech>
> Cc: bruce.richardson at intel.com; Ruifeng.Wang at arm.com;
> Honnappa.Nagarahalli at arm.com; Phil.Yang at arm.com;
> vcchunga at amazon.com; Dharmik.Thakkar at arm.com; jerinjacobk at gmail.com;
> hemant.agrawal at nxp.com; ajit.khaparde at broadcom.com;
> ferruh.yigit at intel.com; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v12 11/14] build: disable Arm drivers
> 
> 16/11/2020 08:56, Juraj Linkeš:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > >
> > > What do you mean by "disable Arm drivers"?
> > > What are "Arm drivers"
> > >
> >
> > These are the drivers that we're disableing for Arm builds. I'll change it to
> something more clearer like "disable drivers in Arm builds"
> >
> > > 13/11/2020 15:31, Juraj Linkeš:
> > > > A few options that disabled drivers in the old makefiles were
> > > > improperly ported to the meson build system. Fix this by adding a
> > > > to the list of disabled drivers, similarly how the command line
> > > > option works. Remove unneeded driver options ported from the old
> makefile system.
> > > > Add support for removing drivers for cross builds.
> > > >
> > > > Signed-off-by: Juraj Linkeš <juraj.linkes at pantheon.tech>
> > > > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> > > [...]
> > > > -	['RTE_NET_FM10K', false],
> > > > -	['RTE_NET_AVP', false],
> > >
> > > Isn't it enabling drivers?
> > >
> >
> > These options don't do anything in the way the current meson build system is
> set up, since they'll be overwritten in drivers/meson.build. The order is, from
> meson.build (in the git root):
> > subdir('config')   # here we're setting arm specific flags
> > ...
> > subdir('drivers')  # and here they'd be overwritten
> 
> Should this change be in the same patch as disabling some drivers?
> If yes, please explain in the commit log.
> 

I think so, the fix consist not only of adding support for disabling drivers, but also removing the parts that look like they're doing that but fail to do so (so, in essence replacing the faulty config with proper support). I'll update the commit message.

> 
> > > [...]
> > > > +if meson.is_cross_build()
> > > > +	disabled_drivers += meson.get_cross_property('disabled_drivers',
> > > > +[]) endif
> > >
> > > Why is it specific to cross build?
> >
> > I don't understand the question, what is "it"? This is adding support for
> disabling drivers in cross builds so I guess that part is specific to cross builds?
> 
> OK I understand.
> 
> 



More information about the dev mailing list