[dpdk-dev] [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON vector

Wang, Haiyue haiyue.wang at intel.com
Wed Nov 18 09:15:21 CET 2020


> -----Original Message-----
> From: Feifei Wang <Feifei.Wang2 at arm.com>
> Sent: Wednesday, November 18, 2020 15:56
> To: Wang, Haiyue <haiyue.wang at intel.com>; jerinj at marvell.com; Ruifeng Wang <Ruifeng.Wang at arm.com>; Guo,
> Jia <jia.guo at intel.com>
> Cc: dev at dpdk.org; nd <nd at arm.com>; nd <nd at arm.com>
> Subject: 回复: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON vector
> 
> Hi, Haiyue
> 
> > -----邮件原件-----
> > 发件人: Wang, Haiyue <haiyue.wang at intel.com>
> > 发送时间: 2020年11月18日 15:22
> > 收件人: Feifei Wang <Feifei.Wang2 at arm.com>; jerinj at marvell.com; Ruifeng
> > Wang <Ruifeng.Wang at arm.com>; Guo, Jia <jia.guo at intel.com>
> > 抄送: dev at dpdk.org; nd <nd at arm.com>
> > 主题: RE: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON
> > vector
> >
> > > -----Original Message-----
> > > From: Feifei Wang <feifei.wang2 at arm.com>
> > > Sent: Wednesday, November 18, 2020 14:29
> > > To: Jerin Jacob <jerinj at marvell.com>; Ruifeng Wang
> > > <ruifeng.wang at arm.com>; Guo, Jia <jia.guo at intel.com>; Wang, Haiyue
> > > <haiyue.wang at intel.com>
> > > Cc: dev at dpdk.org; nd at arm.com; feiwan02 <feifei.wang2 at arm.com>
> > > Subject: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for
> > > NEON vector
> > >
> > > From: feiwan02 <feifei.wang2 at arm.com>
> > >
> > > Add CKSUM_GOOD flag to distinguish a good checksum from an unknown
> > one
> > > in neon vertor RX function.
> > >
> > > Test Results:
> > > NICs: 82599(igb)
> > > Dirver: ixgbe(vector)
> > > Packet: IPv4_checksum = correct value && UDP_checksum = correct value
> > >
> > > $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i
> > > --port-topology=chained
> > > test-pmd> set fwd rxonly
> > > test-pmd> set verbose 1
> > > test-pmd> start
> > >
> > > With this patch:
> > > testpmd> port 0/queue 0: received 1 packets
> > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 -
> > > length=70 - nb_segs=1
> > > ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD
> > >
> > > Without this patch:
> > > testpmd> port 0/queue 0: received 1 packets
> > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 -
> > > length=70 - nb_segs=1
> > > ol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_UNKNOWN
> > >
> >
> > How about to merge "1 & 2" and "3 & 4"? Then you will have the above test
> > result. ;-)
> Do you mean that combine patch 1 and patch 2 into one patch to support vlan stripping and bad checksum
> flag,
> Then also do the same work for patch 3 and patch 4 to support good checksum flag and enable IXGBE neon
> vector when DEV_RX_OFFLOAD_CHECKSUM is set?
> 
> Actually, the test results are achieved without patch 4, due to that testpmd does not check rxmode-
> >offloads, it will call IXGBE NEON vector function directly. And this change
> is for the default config of l3fwd example.
> 

I was messed by the vector code, sorry. Patch b is for bad checksum,
update the commit message to align your design. Then the patch set
is OF for me, thanks!

Feifei Wang (4):
  a). net/ixgbe: add VLAN stripping support for Arm
  b). net/ixgbe: support checksum flags for NEON vector
  c). net/ixgbe: implement good checksum flag for NEON vector
  d). net/ixgbe: enable IXGBE NEON vector PMD when CHECKSUM is set

> Best Regards
> Feifei
> >
> > > Signed-off-by: Feifei Wang <feifei.wang2 at arm.com>
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> > > ---
> > > 2.17.1



More information about the dev mailing list