[dpdk-dev] [PATCH v1 0/2] remove some limitations and operations

Ferruh Yigit ferruh.yigit at intel.com
Tue Nov 24 10:31:39 CET 2020


On 11/23/2020 4:09 PM, Ferruh Yigit wrote:
> On 11/23/2020 1:12 PM, Guoyang Zhou wrote:
>> The maximum number of queues on the chip can be any value greater
>> than 0, it does not have to be the power of two, and remove the
>> operation of optical modules in the link function.
>>
>> -- 
>> v1:
>>    - remove the limitation for max queue num
>>    - remove the operation of optical modules in the link function
>>
>> Guoyang Zhou (2):
>>    net/hinic/base: remove the limitation for max queue num
>>    net/hinic: remove the operation of optical modules
>>
> 
> Hi Guoyang,
> 
> How critical is this set, can you please describe the impact of the fixes?
> 
> If they are not critical, let's postpone them to next release, since the release 
> is a few days away.
> 

Hi Guoyang,

I can see that a v2 has been sent but it is still not clear if you are OK to 
defer the patches, can you please share your thoughts on it?

Thanks,
ferruh

> btw, both patches has [1] as a fixed patch, but that patch looks unrelated with 
> both, that patch only cleans up the uninit/destroy path.
> Can you please elaborate why that patch is fixed?
> 
> As far as I can see the condition removed in first patch introduced in v19.08 
> ([2]) and the calls in second patch added in v19.11 ([3]).
> 
> 
> 
> [1]
> Fixes: 511b7371d32b ("net/hinic: fix hugepage memory leaks")
> 
> 
> [2]
> Fixes: 828d3e15a9dc ("net/hinic/base: support context and work queue")
> 
> [3]
> Fixes: 54ac33869932 ("net/hinic: set link down and up")



More information about the dev mailing list