[dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Thu Nov 26 12:28:15 CET 2020


On 11/24/20 8:36 PM, Ferruh Yigit wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

A couple of questions below, but anyway:

Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>

> ---
> Cc: Thomas Monjalon <thomas at monjalon.net>
> Cc: Andrew Rybchenko <arybchenko at solarflare.com>
> Cc: Konstantin Ananyev <konstantin.ananyev at intel.com>
> Cc: Matan Azrad <matan at nvidia.com>
> Cc: Olivier Matz <olivier.matz at 6wind.com>
> Cc: Jerin Jacob <jerinj at marvell.com>
> 
> v2:
> * ``uint32_t mtu`` moved to ``struct rte_eth_conf``
> * The "Driver is responsible from updating ``(struct
>   rte_eth_dev)->data->mtu``" updated because ethdev layer also can do
>   this. The intention there was both APIs should update the variable.
> 
> Another open question is from Andrew, if we can remove the ``uint32_t
> max_rx_pkt_len`` completely from the ``rte_eth_dev_configure()``.
> This may force applications to have one more additional
> ``rte_eth_dev_set_mtu()`` call for device initialization, but if
> applications are OK with the default values most of times, agree that
> removing is easier solution, please comment.

Still valid plus I'd remove JUMBO_FRAME offload since
it is redundant. We have max_mtu and max_rx_pktlen in dev_info.


More information about the dev mailing list