[dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses

Nipun Gupta nipun.gupta at nxp.com
Wed Oct 7 07:35:07 CEST 2020


Acked by: Nipun Gupta <nipun.gupta at nxp.com>

> -----Original Message-----
> From: wangyunjian <wangyunjian at huawei.com>
> Sent: Wednesday, September 9, 2020 6:42 AM
> To: dev at dpdk.org
> Cc: Nipun Gupta <nipun.gupta at nxp.com>; jerry.lilijun at huawei.com;
> xudingke at huawei.com; Yunjian Wang <wangyunjian at huawei.com>;
> stable at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
> 
> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> This issue detected by coverity, CID#279443(Structurally dead code).
> 
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> ---
> v2: fix spelling in commit log
> ---
>  drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
>  	/* In case there are pending jobs on any VQ, return -EBUSY */
>  	for (i = 0; i < qdma_dev.max_vqs; i++) {
>  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> -		    qdma_vqs[i].num_dequeues))
> +		    qdma_vqs[i].num_dequeues)) {
>  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> i);
>  			return -EBUSY;
> +		}
>  	}
> 
>  	/* Reset HW queues */
> --
> 2.18.1
> 



More information about the dev mailing list