[dpdk-dev] [PATCH 19/22] event/dlb2: add PMD self-tests

[Eads, Gage]

> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Sent: Friday, September 11, 2020 3:26 PM
> To: Jerin Jacob <jerinj at marvell.com>
> Cc: dev at dpdk.org; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>
> Subject: [PATCH 19/22] event/dlb2: add PMD self-tests
> 
> Add a variety of self-tests for both ldb and directed
> ports/queues, as well as configure, start, stop, link, etc...
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> ---
>  app/test/test_eventdev.c           |    9 +
>  drivers/event/dlb2/dlb2.c          |    1 +
>  drivers/event/dlb2/dlb2_selftest.c | 1570
> ++++++++++++++++++++++++++++++++++++
>  drivers/event/dlb2/meson.build     |    3 +-
>  4 files changed, 1582 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/event/dlb2/dlb2_selftest.c
> 
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index 43ccb1c..b8d8df8 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -1030,6 +1030,13 @@ test_eventdev_selftest_dpaa2(void)
>  	return test_eventdev_selftest_impl("event_dpaa2", "");
>  }
> 
> +static int
> +test_eventdev_selftest_dlb2(void)
> +{
> +	return test_eventdev_selftest_impl("dlb2_event", "");
> +}
> +
> +

Nit: extra newline

>  REGISTER_TEST_COMMAND(eventdev_common_autotest,
> test_eventdev_common);
>  REGISTER_TEST_COMMAND(eventdev_selftest_sw,
> test_eventdev_selftest_sw);
>  REGISTER_TEST_COMMAND(eventdev_selftest_octeontx,
> @@ -1037,3 +1044,5 @@
> REGISTER_TEST_COMMAND(eventdev_selftest_octeontx,
>  REGISTER_TEST_COMMAND(eventdev_selftest_octeontx2,
>  		test_eventdev_selftest_octeontx2);
>  REGISTER_TEST_COMMAND(eventdev_selftest_dpaa2,
> test_eventdev_selftest_dpaa2);
> +REGISTER_TEST_COMMAND(eventdev_selftest_dlb2,
> test_eventdev_selftest_dlb2);
> +

Nit: newline at the end of the file

> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 43b85d7..620a0a5 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c

[...]

> +/* destruction */
> +static inline void
> +cleanup(struct test *t __rte_unused)

Since 't' is unused, just drop the parameter.

With that and the whitespace issues fixed:
Reviewed-by: Gage Eads <gage.eads at intel.com>

Thanks,
Gage