[dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor

[Ferruh Yigit]

On 9/27/2020 8:26 AM, Robin Zhang wrote:
> Add implementation of inline API rx_descriptor_done in iavf PMD.
> 
> Signed-off-by: Robin Zhang <robinx.zhang at intel.com>
> ---
>   drivers/net/iavf/iavf_ethdev.c |  1 +
>   drivers/net/iavf/iavf_rxtx.c   | 26 ++++++++++++++++++++++++++
>   drivers/net/iavf/iavf_rxtx.h   |  1 +
>   3 files changed, 28 insertions(+)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 836c09f58..b7a819a0e 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
>   	/* assign ops func pointer */
>   	eth_dev->dev_ops = &iavf_eth_dev_ops;
>   	eth_dev->rx_queue_count = iavf_dev_rxq_count;
> +	eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done;
>   	eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status;
>   	eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status;

Hi Robin,

'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should 
provide same information?

Is there a specific reason/need to implement 'rx_descriptor_done'? If not I will 
drop this patch.