[dpdk-dev] [PATCH v4 14/22] event/dlb: add eventdev start

Eads, Gage gage.eads at intel.com
Thu Oct 8 23:41:18 CEST 2020



> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Sent: Friday, September 11, 2020 2:19 PM
> Cc: dev at dpdk.org; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>;
> jerinj at marvell.com
> Subject: [PATCH v4 14/22] event/dlb: add eventdev start
> 
> Add support for the eventdev start entry point.
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> ---
>  drivers/event/dlb/dlb.c                  | 225 +++++++++++++++++++++++++------
>  drivers/event/dlb/dlb_iface.c            |   3 +
>  drivers/event/dlb/dlb_iface.h            |   3 +
>  drivers/event/dlb/pf/base/dlb_resource.c | 142 +++++++++++++++++++
>  drivers/event/dlb/pf/dlb_pf.c            |  23 ++++
>  5 files changed, 352 insertions(+), 44 deletions(-)
> 
> diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
> index 4f56869..5f2a7fa 100644
> --- a/drivers/event/dlb/dlb.c
> +++ b/drivers/event/dlb/dlb.c
> @@ -1443,6 +1443,7 @@ dlb_eventdev_ldb_queue_setup(struct rte_eventdev
> *dev,
>  	return 0;
>  }
> 
> +

^^^ Extra newline

Same with the dlb2 patch, I think this warrants a detailed commit message. The code looks
fine though. With that:

Reviewed-by: Gage Eads <gage.eads at intel.com>

Thanks,
Gage


More information about the dev mailing list