[dpdk-dev] [PATCH v4 19/22] event/dlb: add PMD self-tests
Eads, Gage
gage.eads at intel.com
Thu Oct 8 23:56:00 CEST 2020
> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Sent: Friday, September 11, 2020 2:19 PM
> To: Jerin Jacob <jerinj at marvell.com>
> Cc: dev at dpdk.org; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>
> Subject: [PATCH v4 19/22] event/dlb: add PMD self-tests
>
> Add a variety of self-tests for both ldb and directed
> ports/queues, as well as configure, start, stop, link, etc...
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> ---
> app/test/test_eventdev.c | 8 +
> drivers/event/dlb/dlb.c | 1 +
> drivers/event/dlb/dlb_selftest.c | 1563
> ++++++++++++++++++++++++++++++++++++++
> drivers/event/dlb/meson.build | 1 +
> 4 files changed, 1573 insertions(+)
> create mode 100644 drivers/event/dlb/dlb_selftest.c
>
> diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
> index 62019c1..2f6ad49 100644
> --- a/app/test/test_eventdev.c
> +++ b/app/test/test_eventdev.c
> @@ -1030,6 +1030,13 @@ test_eventdev_selftest_dpaa2(void)
> return test_eventdev_selftest_impl("event_dpaa2", "");
> }
>
> +static int
> +test_eventdev_selftest_dlb(void)
> +{
> + return test_eventdev_selftest_impl("dlb_event", "");
> +}
> +
> +
Nit: extra newline
[...]
> +/* destruction */
> +static inline int
> +cleanup(struct test *t __rte_unused)
No need for 't'
> +{
> + int ret;
> +
> + rte_event_dev_stop(evdev);
> + ret = rte_event_dev_close(evdev);
> + if (ret)
This can simply be if (rte_event_dev_close(evdev))
> + return -1;
> +
> + return 0;
> +};
> +
With those and the whitespace issue fixed:
Reviewed-by: Gage Eads <gage.eads at intel.com>
Thanks,
Gage
More information about the dev
mailing list