[dpdk-dev] [PATCH v8 8/8] sched: remove redundant code

Thomas Monjalon thomas at monjalon.net
Fri Oct 9 10:28:32 CEST 2020


Hi,

> Remove redundant data structure fields references from
> functions and subport level data structures. It also
> update the release and deprecation note
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa at intel.com>
> ---
> 
>  doc/guides/rel_notes/deprecation.rst   |  6 ----
>  doc/guides/rel_notes/release_20_11.rst |  1 +
>  lib/librte_sched/rte_sched.c           | 42 ++------------------------
>  lib/librte_sched/rte_sched.h           | 12 --------

I wonder why this patch exists.

Documentation updates should be done when adding the feature (patch 3).
Please try to conform to the release notes format and recommendations.

Redundant code should be removed when it becomes useless.
Or should it be last because the fields are used in apps?
Anyway it is strange that a test for params->qsize is added.

About the API changes, please update the ABI section of the release notes
in each patch removing some old API.




More information about the dev mailing list