[dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-Poly1305

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Oct 9 20:33:32 CEST 2020


Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal at nxp.com>
> Sent: Friday, October 9, 2020 2:33 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_mb: support Chacha20-
> Poly1305
> 
> > +#if IMB_VERSION(0, 54, 3) <= IMB_VERSION_NUM
> > +	{	/* CHACHA20-POLY1305 */
> > 	\
> > +		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> > 	\
> > +		{.sym = {						\
> > +			.xform_type = RTE_CRYPTO_SYM_XFORM_AEAD,
> > 	\
> > +			{.aead = {					\
> > +				.algo =
> > RTE_CRYPTO_AEAD_CHACHA20_POLY1305, \
> > +				.block_size = 64,			\
> > +				.key_size = {				\
> > +					.min = 32,			\
> > +					.max = 32,			\
> > +					.increment = 0			\
> > +				},					\
> > +				.digest_size = {			\
> > +					.min = 16,			\
> > +					.max = 16,			\
> > +					.increment = 0			\
> > +				},					\
> > +				.aad_size = {				\
> > +					.min = 0,			\
> > +					.max = 240,			\
> > +					.increment = 1			\
> > +				},					\
> > +				.iv_size = {				\
> > +					.min = 12,			\
> > +					.max = 12,			\
> > +					.increment = 0			\
> > +				},					\
> > +			}, }						\
> > +		}, }							\
> > +	},
> >  #endif
> >  	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> >  };
> 
> These line breaks are not needed. Rest of the caps are also not having it.

You are right, sorry. I got this from QAT PMD and I forgot to remove these line breaks.
Can you remove them when applying it?

Thanks!
Pablo


More information about the dev mailing list