[dpdk-dev] [PATCH v3] ethdev: check if queue setupped in queue-related APIs

Stephen Hemminger stephen at networkplumber.org
Mon Oct 12 17:15:16 CEST 2020


On Mon, 12 Oct 2020 15:32:44 +0800
"Wei Hu (Xavier)" <huwei013 at chinasoftinc.com> wrote:

> From: Chengchang Tang <tangchengchang at huawei.com>
> 
> This patch adds checking whether the related Tx or Rx queue has been
> setupped in the queue-related API functions to avoid illegal address
> access. And validity check of the queue_id is also added in the API
> functions rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable.
> 
> Signed-off-by: Chengchang Tang <tangchengchang at huawei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
> Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>

Looks good. If you make another version (or when committing)
Lets change the subject line and commit text to replace "setupped" 
since that is not an English word; the proper word would be setup.

https://www.quora.com/What-is-the-past-tense-of-to-set-up-What-are-some-examples?share=1

Acked-by: Stephen Hemminger <stephen at networkplumber.org>



More information about the dev mailing list