[dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support

[Guy Kaneti]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, October 12, 2020 8:11 PM
> To: Guy Kaneti <guyk at marvell.com>
> Cc: orika at mellanox.com; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>; mdr at ashroe.eu;
> nhorman at tuxdriver.com; bruce.richardson at intel.com;
> anatoly.burakov at intel.com; john.mcnamara at intel.com;
> marko.kovacevic at intel.com; dev at dpdk.org; Smadar Fuks
> <smadarf at marvell.com>; Dovrat Zifroni <dovrat at marvell.com>; Liron Himi
> <lironh at marvell.com>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build
> infra and device support
> 
> 12/10/2020 19:06, Guy Kaneti:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > 12/10/2020 13:31, guyk at marvell.com:
> > > > --- a/meson_options.txt
> > > > +++ b/meson_options.txt
> > > > +option('ree_compiler_sdk', type: 'string', value: '',
> > > > +	description: 'path to REE compiler SDK optional library for regex
> > > device')
> > >
> > > Is this SDK specific to Marvell or octeontx2?
> > > If yes, it should appear here.
> >
> > Yes, it is specific to Marvell.
> >
> > >
> > > Why this SDK requires setting the path manually?
> > > Well designed libs should use pkg-config.
> 
> You didn't reply this question.
> Really I would prefer avoiding this ugly meson option.
> Please rework the REE SDK to use pkg-config.
> 
It is required to be set manually mainly when cross compiling 
The target library will not be part of the host system.