[dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid

Thomas Monjalon thomas at monjalon.net
Tue Oct 13 17:47:45 CEST 2020


13/10/2020 17:32, Ferruh Yigit:
> On 10/13/2020 3:53 PM, Andrew Rybchenko wrote:
> > Use ENODEV as the error code if specified port ID is invalid.
> > 
> > Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> > ---
> >   lib/librte_ethdev/rte_ethdev.c | 44 ++++++++++++++++----------------
> >   lib/librte_ethdev/rte_ethdev.h | 46 +++++++++++++++++++++++-----------
> >   2 files changed, 54 insertions(+), 36 deletions(-)
> > 
> > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> > index 5b7979a3b8..1f862f918a 100644
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > @@ -784,7 +784,7 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, char *name)
> >   {
> >   	char *tmp;
> >   
> > -	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
> > +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> 
> Thanks Andrew, +1 to this error unification.
> 
> This will be API change without deprecation notice, cc'ed techboard for it.

This is an error code change, unifying assumptions across ethdev,
I would say yes to merge in 20.11.




More information about the dev mailing list