[dpdk-dev] [PATCH v6] eal: add cache-line demote support

[Ruifeng Wang]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Wednesday, October 14, 2020 3:14 PM
> To: Bruce Richardson <bruce.richardson at intel.com>; Ruifeng Wang
> <Ruifeng.Wang at arm.com>
> Cc: Omkar Maslekar <omkar.maslekar at intel.com>; dev at dpdk.org;
> ciara.loftus at intel.com; drc at linux.vnet.ibm.com; jerinj at marvell.com;
> Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>; nd <nd at arm.com>
> Subject: Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support
> 
> On Tue, Oct 13, 2020 at 6:21 PM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> > > 1. Experimental tag is only needed in this file. Tags at other places can be
> removed.
> >
> > I'm not sure that is the case. The generic file is used when preparing
> > the docs, so the experimental tag needs to go there for the docs, but
> > when actually using the function in compiled code the "generic"
> > version is unused. Therefore we need the experimental tag there to
> > trigger a build warning about using the function if the appropriate
> > ALLOW_EXPERIMENTAL_APIS flag is not set.
> 
> It is enough to put an experimental tag when declaring a symbol.
> Here, the generic/ header only contains the doxygen part and there is no
> common declaration: the tag is needed in the arch specific header.
> 
Thank you David for the clarification.

I added my reviewed-by tag to v7.
> 
> --
> David Marchand