[dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

Eads, Gage gage.eads at intel.com
Wed Oct 14 17:37:21 CEST 2020



> -----Original Message-----
> From: Kinsella, Ray <mdr at ashroe.eu>
> Sent: Wednesday, October 14, 2020 4:31 AM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>; Jerin Jacob
> <jerinj at marvell.com>; Neil Horman <nhorman at tuxdriver.com>
> Cc: dev at dpdk.org; Carrillo, Erik G <erik.g.carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>
> Subject: Re: [PATCH] eventdev: add PCI probe named convenience function
> 
> 
> 
> On 12/10/2020 19:42, Timothy McDaniel wrote:
> > Add new internal wrapper function for use by pci drivers as a
> > .probe function to attach to an event interface.  Same as
> > rte_event_pmd_pci_probe, except the caller can specify the name.
> >
> > Updated rte_event_pmd_pci_probe so as to not duplicate
> > code.
> 
> Any reason why this couldn't be __rte_internal then ?

On a related note...should a static function defined in an internal header file
be included the version.map file? Doesn't that only pertain to symbols in the
.so? Probably harmless if so, but now may be a good time to correct it.

Thanks,
Gage


More information about the dev mailing list