[dpdk-dev] [PATCH v6 0/3] cleanup ethdev close operation

Thomas Monjalon thomas at monjalon.net
Fri Oct 16 15:32:56 CEST 2020


Most of the patches from the v3 have been merged already.
The remaining 3 patches are reworked in v4:
  - reset dev_started in some PMDs
  - selectively reset pointers in rte_eth_dev_release_port()
  - fix error handling

v5: change error code to ENODEV if wrong port id
v6: - use eth_err() in rte_eth_dev_close()
    - fix missed igbvf and ixgbevf


Thomas Monjalon (3):
  ethdev: remove forcing stopped state upon close
  ethdev: reset all when releasing a port
  ethdev: allow close function to return an error

 doc/guides/rel_notes/deprecation.rst    |  1 -
 doc/guides/rel_notes/release_20_11.rst  |  4 +++-
 drivers/net/ark/ark_ethdev.c            |  4 +---
 drivers/net/atlantic/atl_ethdev.c       |  5 +----
 drivers/net/axgbe/axgbe_ethdev.c        |  3 ---
 drivers/net/bnxt/bnxt_ethdev.c          |  4 ----
 drivers/net/bnxt/bnxt_reps.c            |  1 -
 drivers/net/bonding/rte_eth_bond_pmd.c  |  4 ----
 drivers/net/cxgbe/cxgbe_ethdev.c        |  5 +++--
 drivers/net/cxgbe/cxgbevf_ethdev.c      |  5 +++--
 drivers/net/dpaa/dpaa_ethdev.c          |  5 +----
 drivers/net/dpaa2/dpaa2_ethdev.c        |  4 ----
 drivers/net/e1000/em_ethdev.c           |  6 ++----
 drivers/net/e1000/igb_ethdev.c          | 10 ++--------
 drivers/net/ena/ena_ethdev.c            |  6 +-----
 drivers/net/enetc/enetc_ethdev.c        |  1 +
 drivers/net/failsafe/failsafe_ether.c   |  6 +++++-
 drivers/net/failsafe/failsafe_ops.c     | 25 ++++++++++++++++--------
 drivers/net/fm10k/fm10k_ethdev.c        |  5 +----
 drivers/net/hinic/hinic_pmd_ethdev.c    |  6 ++----
 drivers/net/hns3/hns3_ethdev.c          |  5 +----
 drivers/net/hns3/hns3_ethdev_vf.c       |  6 +-----
 drivers/net/i40e/i40e_ethdev.c          |  5 +----
 drivers/net/i40e/i40e_ethdev_vf.c       |  6 +-----
 drivers/net/iavf/iavf_ethdev.c          |  5 +----
 drivers/net/ice/ice_dcf_ethdev.c        |  4 ----
 drivers/net/ice/ice_ethdev.c            |  5 +----
 drivers/net/igc/igc_ethdev.c            |  1 +
 drivers/net/ionic/ionic_ethdev.c        |  5 -----
 drivers/net/ixgbe/ixgbe_ethdev.c        | 10 ++--------
 drivers/net/kni/rte_eth_kni.c           |  1 +
 drivers/net/liquidio/lio_ethdev.c       |  5 +----
 drivers/net/memif/rte_eth_memif.c       |  4 +---
 drivers/net/mlx5/mlx5.c                 |  7 ++++---
 drivers/net/mvneta/mvneta_ethdev.c      |  7 +++++--
 drivers/net/mvpp2/mrvl_ethdev.c         |  5 +++--
 drivers/net/netvsc/hn_ethdev.c          | 11 +++++------
 drivers/net/netvsc/hn_var.h             |  2 +-
 drivers/net/netvsc/hn_vf.c              |  7 +++++--
 drivers/net/nfb/nfb_ethdev.c            |  2 ++
 drivers/net/octeontx/octeontx_ethdev.c  |  3 ---
 drivers/net/pfe/pfe_ethdev.c            |  2 ++
 drivers/net/qede/qede_ethdev.c          |  5 +----
 drivers/net/ring/rte_eth_ring.c         |  1 +
 drivers/net/sfc/sfc_ethdev.c            |  7 +------
 drivers/net/szedata2/rte_eth_szedata2.c |  2 ++
 drivers/net/tap/rte_eth_tap.c           |  1 -
 drivers/net/thunderx/nicvf_ethdev.c     |  1 +
 drivers/net/vhost/rte_eth_vhost.c       |  1 +
 drivers/net/virtio/virtio_ethdev.c      |  5 +----
 drivers/net/virtio/virtio_user_ethdev.c |  4 +---
 drivers/net/vmxnet3/vmxnet3_ethdev.c    |  6 +-----
 lib/librte_ethdev/rte_ethdev.c          | 26 +++++++++++++++++++------
 lib/librte_ethdev/rte_ethdev.h          |  5 ++++-
 54 files changed, 116 insertions(+), 166 deletions(-)

-- 
2.28.0



More information about the dev mailing list