[dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

[Wang, Haiyue]

> -----Original Message-----
> From: Andrew Rybchenko <arybchenko at solarflare.com>
> Sent: Sunday, October 18, 2020 22:09
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Xing, Beilei <beilei.xing at intel.com>; Iremonger, Bernard
> <bernard.iremonger at intel.com>; Ray Kinsella <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>; Ajit
> Khaparde <ajit.khaparde at broadcom.com>; Somnath Kotur <somnath.kotur at broadcom.com>; John Daley
> <johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>; Guo, Jia <jia.guo at intel.com>; Wang, Haiyue
> <haiyue.wang at intel.com>; Matan Azrad <matan at nvidia.com>; Shahaf Shuler <shahafs at nvidia.com>;
> Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Rasesh Mody <rmody at marvell.com>; Shahed Shaikh
> <shshaikh at marvell.com>; Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>; Thomas Monjalon
> <thomas at monjalon.net>; Yigit, Ferruh <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org
> Subject: [PATCH 12/14] ethdev: remove legacy FDIR filter type support
> 
> RTE flow API should be used for filtering.
> 
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> ---
>  app/test-pmd/cmdline.c               | 897 +++------------------------
>  app/test-pmd/config.c                |  15 +-
>  app/test-pmd/testpmd.h               |   2 +
>  doc/guides/rel_notes/deprecation.rst |   4 +-
>  drivers/net/bnxt/bnxt_ethdev.c       | 396 ------------
>  drivers/net/enic/enic.h              |   7 -
>  drivers/net/enic/enic_clsf.c         | 168 -----
>  drivers/net/enic/enic_ethdev.c       |  48 --
>  drivers/net/i40e/i40e_ethdev.c       |  86 ---
>  drivers/net/i40e/i40e_ethdev.h       |  11 +-
>  drivers/net/i40e/i40e_fdir.c         | 539 ----------------
>  drivers/net/ixgbe/ixgbe_ethdev.c     |   5 +-
>  drivers/net/ixgbe/ixgbe_ethdev.h     |   2 -
>  drivers/net/ixgbe/ixgbe_fdir.c       | 220 -------
>  drivers/net/mlx5/mlx5.h              |   1 -
>  drivers/net/mlx5/mlx5_flow.c         | 516 ---------------
>  drivers/net/mlx5/mlx5_flow.h         |   8 -
>  drivers/net/qede/qede_ethdev.h       |   5 -
>  drivers/net/qede/qede_filter.c       | 171 -----
>  drivers/net/sfc/sfc_ethdev.c         |   3 -
>  lib/librte_ethdev/rte_eth_ctrl.h     |  27 +-
>  21 files changed, 81 insertions(+), 3050 deletions(-)
> 

Thanks Andrew, removing the legacy filter from deprecation note, testpmd,
lib, to PMDs per type is very clear, and easy to review.

Very appreciate your professional work! ;-)

For ixgbe PMD,

Acked-by: Haiyue Wang <haiyue.wang at intel.com>

> --
> 2.17.1