[dpdk-dev] [PATCH 06/22] event/dlb2: add probe

[McDaniel, Timothy]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Sunday, October 18, 2020 4:06 AM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov at intel.com>; dpdk-dev <dev at dpdk.org>;
> Carrillo, Erik G <Erik.G.Carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>;
> Jerin Jacob <jerinj at marvell.com>
> Subject: Re: [dpdk-dev] [PATCH 06/22] event/dlb2: add probe
> 
> On Sat, Sep 12, 2020 at 2:01 AM Timothy McDaniel
> <timothy.mcdaniel at intel.com> wrote:
> >
> > The DLB2 hardware is a PCI device. This commit adds
> > support for probe and other initialization. The
> > dlb2_iface.[ch] files implement a flexible interface
> > that supports both the PF PMD and the bifurcated PMD.
> > The bifurcated PMD will be released in a future
> > patch set. Note that the flexible interface is only
> > used for configuration, and is not used in the data
> > path. The shared code is added in pf/base.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> 
> > +static void
> > +dlb2_qm_mmio_fn_init(void)
> > +{
> > +       /* Process-local function pointers for performing low level port i/o */
> > +
> > +       if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_MOVDIR64B))
> > +               qm_mmio_fns.pp_enqueue_four = dlb2_movdir64b;
> > +       else
> > +               qm_mmio_fns.pp_enqueue_four = dlb2_movntdq;
> > +}
> > +
> > +#define RTE_BASE_10 10
> 
> DONT create RTE_ symbols in drivers as it will create conflict if
> someone adds such symbols in the future in EAL.
> Either make it an internal symbol or push an EAL patch.
> 
> Also please split this patch as at minimum as two as it is a huge patch.
> 
> 

Working on this now.